Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works with virtual-dom/vnode/vnode but not vtree/vnode #18

Closed
sekoyo opened this issue Oct 18, 2015 · 1 comment
Closed

Works with virtual-dom/vnode/vnode but not vtree/vnode #18

sekoyo opened this issue Oct 18, 2015 · 1 comment

Comments

@sekoyo
Copy link

sekoyo commented Oct 18, 2015

Hi,

These implementations look very similar to me:

https://github.com/Matt-Esch/virtual-dom/blob/master/vnode/vnode.js
https://github.com/Matt-Esch/vtree/blob/master/vnode.js

However the latter is resulting in an empty result. test:

var toHTML = require('vdom-to-html');

var VNode = require('virtual-dom/vnode/vnode');
// var VNode = require('vtree/vnode'); // Doesn't work

toHTML(new VNode('input', { className: 'name', type: 'text' }));

Currently https://github.com/Raynos/mercury is not working either, I'm wondering if it's also using a vnode which is incompatible?

Thanks

@sekoyo
Copy link
Author

sekoyo commented Oct 18, 2015

Turns out this is an issue with Mercury currently needing an older version of virtual-dom, Raynos/mercury#192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant