Cable delay is added to channels in the efieldToVoltageConverter

[fschlueter]

We are adding the cable delay (in the context of the RNO-G detector it is better to talk about the time delay of the entire signal chain including all filters and so on) in the efieldToVoltageConverter module and not with the dedicated cableDelayAdderModule or with the hardwareResponseIncorperator (which would be the more logical place in my opinion).

This causes an issue currently when trying to simulate trigger channels with a different response and thus a different time delay since we only copy the channel after the efieldToVoltageConverter.

[fschlueter]

@cg-laser and @sjoerd-bouma

[fschlueter]

I would suggest to, by default, add the cable delay with the hardwareResponseIncoperator. Simulations which do not make use of such a module can use the cableDelayAdder.

[fschlueter]

Also @jakobhenrichs

[fschlueter]

I attempted to fix that issue in PR #743 but failed for the moment. The current procedure is a practical one i wrong in at least two situations:

• When simulating trigger channels with an independent or partially independent response (as implemented with PR Simulate trigger channels for RNO-G (simplified) #788 - for RNO-G that is currently not a big issue)
• When simulating coherent noise - the noise should be added before adding the cable delay!