feat: batch-map implementation #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 94.65% 94.82% +0.16%
==========================================
Files 52 56 +4
Lines 2003 2184 +181
Branches 119 130 +11
==========================================
+ Hits 1896 2071 +175
- Misses 78 83 +5
- Partials 29 30 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
kohlisid
changed the title
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
ab93
reviewed
Jul 12, 2024
| """ | ||
| self.batch_mapper_instance: BatchMapCallable = batch_mapper_instance | ||
| self.sock_path = f"unix://{sock_path}" | ||
| self.max_threads = min(max_threads, int(os.getenv("MAX_THREADS", "4"))) |
There was a problem hiding this comment.
Let's have a max cap on the threads. Too many is not good. Let's keep a cap at 16
There was a problem hiding this comment.
Defaulting to 4, putting a max cap at 16
Will change for all server types
Signed-off-by: Sidhant Kohli <[email protected]>
ab93
reviewed
Jul 12, 2024
Signed-off-by: Sidhant Kohli <[email protected]>
kohlisid
changed the title
Signed-off-by: Sidhant Kohli <[email protected]>
ab93
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1788