-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When Debugging UI Tests, Visual Studio No Longer Breaks on Exception #150
Comments
Does this also happens with the fixed adapter I enclosed on #143 ? |
Yes. |
Yes, that works... but I never had to do that before. And in my actual UI test it caused the execution to break at least 30 times before I had to add a specific exception for Microsoft.CSharp.RuntimeBinder.RuntimeBinderException. Only then did it finally make it to the MissingHtmlException. Interestingly, immediately after that, it also paused on an exception I hadn't seen before: a "rethrown" MissingHtmlException wrapped in an NUnit.Core.NUnitException. I think that might be important. I can approximate the old behavior by setting up my Exception Settings like this: But it's not ideal. I have to inspect the .InnerException property to find the problem. And when it pauses, the call stack looks like this: Whereas the call stack used to show my code. I'm not convinced that something didn't get broken here. It seems like the adapter maybe used to rethrow that NUnitCoreException.InnerException. |
I downgraded to v2.0 of the VS Adapter and used the default exception settings and... it did not pause on the MissingHtmlException. I am going to have to do more investigation to figure out what changed here. |
Ok, at least that makes sense. When you're in there, please also check on the 2.0 adapter whether you get the exception wrapping the same way. |
I'll close this for now. If you find something here that really doesn't work, we can just reopen the issue. |
Visual Studio is no longer pausing execution while debugging NUnit/Coypu UI tests. In Debug Output, it is showing an InvalidOperationException and an IOException related to attempting to communicate over a pipe that has already been broken/terminated.
It used to break automatically on these exceptions and let you inspect the program. Now it seems to just crash when it encounters an unhandled exception.
I thought this issue might be related to #143 or just a misconfiguration on my end. But even after using the pre-release adapter provided in #143, this continues to be a problem.
I added the class BreaksOnCoypuExceptionTest to the repro solution I provided in #143 that reproduces this problem.
break-nunit-adapter.zip
The text was updated successfully, but these errors were encountered: