Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative index is not detected #6024

Open
nus-se-script opened this issue Nov 17, 2023 · 1 comment
Open

Negative index is not detected #6024

nus-se-script opened this issue Nov 17, 2023 · 1 comment

Comments

@nus-se-script
Copy link

nus-se-script commented Nov 17, 2023

Negative index for delivery is not detected.
Screenshot 2023-11-17 at 5.10.22 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#6018] [original labels: type.FunctionalityBug severity.Medium]
@juliusgambe
Copy link
Contributor

juliusgambe commented Nov 19, 2023

Team's Response

Negative index is detected, thus, the error message include states that there is a problem with the command format as the DELIVERY_ID must be a positive integer and less than the Integer.MAX_VALUE.

Furthemore, the UG already states the definition of the correct command format when DELIVERY_ID and CUSTOMER_ID are included:

photo_2023-11-20 12.24.47.jpeg

Hence, it is more of an issue of specificity of error message which is a feature flaw according to the textbook and as it only gives minor inconvenience to the user, the severity is low.

photo_2023-11-19 22.56.04.jpeg

However, this is already part of planned enhancement #10, thus, it is rejected.

Screenshot 2023-11-19 at 10.51.27 PM.png

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants