Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to create deadlines which go beyond the Cycle period #6026

Open
nus-se-script opened this issue Nov 17, 2023 · 1 comment
Open

Able to create deadlines which go beyond the Cycle period #6026

nus-se-script opened this issue Nov 17, 2023 · 1 comment

Comments

@nus-se-script
Copy link

nus-se-script commented Nov 17, 2023

I tried to add an application deadline which is much after the internship cycle period. LetsGetHired accepts this input and creates the intern application.

add r/Developer n/Google c/June 2018 s/Pending d/12 May 2026

image.png


[original: nus-cs2103-AY2324S1/pe-interim#6023] [original labels: type.FeatureFlaw severity.Medium]
@zsh-eng
Copy link
Contributor

zsh-eng commented Nov 20, 2023

Team's Response

Thanks for pointing this out! However, our team does not believe that this is a bug.

There are 2 main reasons why the deadline specified can be any date.

  1. We do not restrict the input for the cycle field, to provide versatility for the user. Thus, users can input Summer or Winter without a year and this input is still accepted. Thus, there is no way to restrict the deadlines based on the cycle.
  2. As per the UG, users are given the flexibility to use the deadline for any other crucial dates. One use case we can think of is putting all "final deadlines" as your graduation date, and in such a case 12 May 2026, which you provided as an input, can be a reasonable deadline.

image.png

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants