Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying VM image uuid (data_source_reference in disk_list) does not replace Disk #159

Open
yannickstruyf3 opened this issue Aug 5, 2020 · 2 comments · May be fixed by #177
Open

Modifying VM image uuid (data_source_reference in disk_list) does not replace Disk #159

yannickstruyf3 opened this issue Aug 5, 2020 · 2 comments · May be fixed by #177

Comments

@yannickstruyf3
Copy link
Collaborator

Nutanix Cluster Information

  • Nutanix Cluster: 5.17.x
  • Nutanix Prism Central: 2020.7

Terraform Version

Terraform v0.12.24

Affected Resource(s)

  • nutanix_virtual_machine

Terraform Configuration Files

Create VM with a disk that references an image:

  disk_list {
    data_source_reference = {
      kind = "image"
      uuid = <image_id_1>
    }
    # disk_size_bytes = 90 * 1024 * 1024 * 1024
  }

Change the image id and apply:

  disk_list {
    data_source_reference = {
      kind = "image"
      uuid = <image_id_1>
    }
    # disk_size_bytes = 90 * 1024 * 1024 * 1024
  }

Debug Output

None

Panic Output

None

Expected Behavior

Change is visible in terraform plan and the disk image is swapped after terraform apply

Actual Behavior

Change is visible in terraform plan and but the disk image on the VM stays identical to the initial configuration. This also results in the fact that re-running terraform apply will keep on indicating that there is a new change.

Steps to Reproduce

  1. Create a VM with an image
  2. Update the image UUID
  3. Apply the modified config

Important Factors

Using Prism Central

References

--->

  • #0000 <!---Github Issue number --->
@yannickstruyf3
Copy link
Collaborator Author

Alternative approach would be to set ForceNew on the image disk.

@marinsalinas
Copy link
Contributor

Copying from slack's conversation:

I think customize diff (#173) could not work for us:
I tested it by changing without any luck:

  • data_source_reference to typelist.
  • change disk_list to typeSet
  • removing computed values from disk_list and test.

We can get the change only by adding or removing elements as your current implementation (#157), also I upgraded the provider to the new terraform SDK v1 to see if the behavior is different.

Also, I got from Hashicorp: customizediff is sort of actively discouraged, despite not having a replacement

cc @yannickstruyf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants