Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare a minor release (v2.3.1) #701

Closed
9 tasks done
guihkx opened this issue Sep 30, 2024 · 10 comments · Fixed by #705
Closed
9 tasks done

Prepare a minor release (v2.3.1) #701

guihkx opened this issue Sep 30, 2024 · 10 comments · Fixed by #705

Comments

@guihkx
Copy link
Collaborator

guihkx commented Sep 30, 2024

This is needed because the AppImages of release 2.3.0 are broken.

@nuttyartist Let me know if your schedule is tight and I can handle this release (I'll open a PR for review first).


TODO:

@nuttyartist
Copy link
Owner

Yes, please do!

@nuttyartist
Copy link
Owner

Shouldn't we just re-upload the 2.3.0 AppImages, actually?

@guihkx
Copy link
Collaborator Author

guihkx commented Sep 30, 2024

Shouldn't we just re-upload the 2.3.0 AppImages, actually?

I really dislike changing already-released binaries like that. It's a really bad practice, IMHO.

I think we should just edit the 2.3.0 release, and put a notice there informing users that the AppImages are broken, and that they should use 2.3.1 instead...

@nuttyartist
Copy link
Owner

Fair, we should inform users. Let's do it.

@nuttyartist
Copy link
Owner

I added a few more TODOs (:

@guihkx
Copy link
Collaborator Author

guihkx commented Oct 1, 2024

@nuttyartist I noticed that the Notes.2.3.0.dmg file in release v2.3.0, points to the Qt 5 build, instead of the Qt 6 (x86_64 + arm64) one. Is that intended?

@guihkx
Copy link
Collaborator Author

guihkx commented Oct 1, 2024

I think that was a mistake, because in v2.2.0, Notes.2.2.0.dmg is the Qt 6 build, which makes more sense, IMO.

@nuttyartist
Copy link
Owner

@nuttyartist I noticed that the Notes.2.3.0.dmg file in release v2.3.0, points to the Qt 5 build, instead of the Qt 6 (x86_64 + arm64) one. Is that intended?

Nope, it is a mistake! Good catch.

@zjeffer
Copy link
Collaborator

zjeffer commented Oct 1, 2024

Updated the aur package: https://aur.archlinux.org/packages/notes

@guihkx
Copy link
Collaborator Author

guihkx commented Oct 1, 2024

Well done, I completely forgot about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants