Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Support native selection mode in Chromium #17591

Open
cary-rowen opened this issue Jan 7, 2025 · 1 comment
Open

Feature request: Support native selection mode in Chromium #17591

cary-rowen opened this issue Jan 7, 2025 · 1 comment
Labels
app/chrome feature/browse-mode feature p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.

Comments

@cary-rowen
Copy link
Contributor

cary-rowen commented Jan 7, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe.

We've supported Firefox native selection mode in #15830.

This allows NVDA to operate the browser's selection functionality within its own virtual document.

cc @michaelDCurran pointed out in the original implementation:

Chromium implemented IAccessibleTextSelectionContainer, however much of the time its offset calculation seems to be wrong, thus the wrong native selection is made, thus this cannot be supported in Chromium at this point in time.

But now things have changed, as Chromium engineer cc @aleventhal stated in this comment

I believe the Chromium bugs with IAccessibleTextSelectionContainer are fixed in the latest Canary, so NVDA could try turning on support again. Let us know if there are new bugs that you see!

Describe the solution you'd like

Implement native selection mode in Chromium.

Describe alternatives you've considered

None

Additional context

Not yet
@Emil-18
Copy link
Contributor

Emil-18 commented Jan 8, 2025

I think JAWS has had this functionality a very long time

@gerald-hartig gerald-hartig added the triaged Has been triaged, issue is waiting for implementation. label Jan 13, 2025
@gerald-hartig gerald-hartig mentioned this issue Jan 13, 2025
Closed
@gerald-hartig gerald-hartig added feature/browse-mode p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority app/chrome feature labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/chrome feature/browse-mode feature p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cary-rowen @Emil-18 @gerald-hartig