Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cd_quotes rule #1373

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add cd_quotes rule #1373

wants to merge 2 commits into from

Conversation

FireFragment
Copy link 

> cd Some folder
cd: string not in pwd: Some
> fuck
cd "Some folder" [enter/↑/↓/ctrl+c]

This rule fixes forgotten quotes around directory containing spaces names when using cd.

The rule has priority 900 to override the cd_mkdir rule.

@FireFragment
Add cd_quotes rule
1781992 
This rule fixes forgotten quotes around directory name, when using cd.

It has priority 900 to override the `cd_mkdir` rule.
@FireFragment FireFragment marked this pull request as draft April 17, 2023 14:02
@FireFragment FireFragment marked this pull request as ready for review April 17, 2023 14:10
djh82
djh82 reviewed Jul 9, 2023
View reviewed changes
Copy link
Contributor

@djh82 djh82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to see some unit tests for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djh82 djh82 djh82 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FireFragment @djh82