Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Install plugins from bundles #68

Open
bottd opened this issue Sep 5, 2024 · 1 comment
Open

[Feature] Install plugins from bundles #68

bottd opened this issue Sep 5, 2024 · 1 comment

Comments

@bottd
Copy link

bottd commented Sep 5, 2024

As a user it would be convenient to configure plugins from alongside bundles. With the current setup we configure a plugin separately from the bundle configuration:

[plugins]
"neodev.nvim"= "scm"
nvim-lspconfig = { version = "0.1.7" } 

[plugins.nvim-cmp]
git = "hrsh7th/nvim-cmp" # Use the git version of nvim-cmp for the best experience.

[bundles.lsp] # Create a bundle called `lsp`
items = [
    "neodev.nvim",
    "nvim-lspconfig",
    "nvim-cmp"
]

Adding a plugin config option like bundle could work:

[plugins]
"neodev.nvim"= { version = "scm", bundle = "lsp"]
nvim-lspconfig = { version = "0.1.7", bundle = "lsp" } 

[plugins.nvim-cmp]
git = "hrsh7th/nvim-cmp" # Use the git version of nvim-cmp for the best experience.
bundle = "lsp"

My intuition is that the implementation of bundles also holding plugin config is more work than a bundle config solution. However I appreciate bundles for offering structure to plugins in rocks.toml. Having plugin config within them would be nice:

[bundles.lsp.plugins]
"neodev.nvim"= "scm"
nvim-lspconfig = { version = "0.1.7" } 

[bundles.lsp.plugins.nvim-cmp]
git = "hrsh7th/nvim-cmp" # Use the git version of nvim-cmp for the best experience.

If not for the bundles.X.config this could be shortened slightly to omit plugins:

[bundles.lsp]
"neodev.nvim"= "scm"
nvim-lspconfig = { version = "0.1.7" } 

[bundles.lsp.nvim-cmp]
git = "hrsh7th/nvim-cmp" # Use the git version of nvim-cmp for the best experience.
@mrcjkb
Copy link
Member

mrcjkb commented Sep 6, 2024

Hey 👋

I quite like the bundles.X.<plugin> suggestion.
We will need to wait for an API in rocks.nvim (one which I was planning to add in order to support rocks-git.nvim anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants