Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NonEmpty for arguments that shouldn't be empty. #306

Open
mrcjkb opened this issue Jan 4, 2025 · 0 comments
Open

Use NonEmpty for arguments that shouldn't be empty. #306

mrcjkb opened this issue Jan 4, 2025 · 0 comments
Assignees
@mrcjkb

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Jan 4, 2025 

          This is also possible without the builder pattern, by passing in an empty vec.

We could change the new constructor to take a NonEmpty<PackageReq>.

I'd be in favour of that, but that would be for a separate PR.

Originally posted by @mrcjkb in #299 (comment)
@mrcjkb mrcjkb self-assigned this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrcjkb mrcjkb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrcjkb