Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent syntax with original fzf #52

Open
simonmandlik opened this issue Jan 8, 2022 · 4 comments · May be fixed by #56
Open

Inconsistent syntax with original fzf #52

simonmandlik opened this issue Jan 8, 2022 · 4 comments · May be fixed by #56

Comments

@simonmandlik
Copy link

Combination of NOT (!) operator and OR (|) works differently than in vanilla fzf.

For example (on this repo with default telescope + fzf-native config):

image

whereas command line fzf gives me

image
@Conni2461
Copy link
Member

I don't guarantee completeness: https://github.com/nvim-telescope/telescope-fzf-native.nvim#disclaimer because its not a 1:1 copy of the go code.

But this looks like a bug in my prompt parsing. I'll look into it if i find the time

@Conni2461 Conni2461 linked a pull request Feb 18, 2022 that will close this issue
Open
@Conni2461
Copy link
Member

finally found some time fixing this issue: #56

Could you try out this PR? dont forget to rerun make :) Thanks

Also please mention if you found any regressions, the tests dont indicate any but i am not sure right now. I havent looked at this code in a while

@Conni2461
Copy link
Member

!a | !b is also borked

@simonmandlik
Copy link
Author

Yes, there are still some problems. !a | !b doesn't work for me either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: invert or a | !a nvim-telescope/telescope-fzf-native.nvim
2 participants
@Conni2461 @simonmandlik