-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Enable installation_iojs test suit in GitHub Actions #3476
base: master
Are you sure you want to change the base?
Conversation
@ljharb , looks like this test suit is passing without issues, except for the v0.40.0 tests that have been failing for a while in production. Is there anyone looking into those? |
Those are expected to fail forever, since v0.40.0 won't ever have the bug fixed. |
Thank you! On regards to the Travis failure: https://app.travis-ci.com/github/nvm-sh/nvm/jobs/628361855 Looks like this failure is the same than the one I just started seeing in the slow test suits. It just started happening and is not an issue with the node version since the same stable version was passing a week before.. I'm gonna continue looking and see if this is something related to anything else.. :( |
I think it's a legit failure in both suites, though - these tests talk to the network and the registry and can have their results change over time, legitimately. |
Remove equivalent TravisCI entries Signed-off-by: Jessica Wagantall <[email protected]>
22496f8
to
0027153
Compare
Actually, I was looking into them a little more and these are indeed legitimate failures I started seeing today in the slow test suit. Even if this change is meant for "installation_iojs", so we need to make sure the slow tests are passing in TravisCI before we could merge this change? |
It would be ideal for maximum confidence to have them passing in travis as well, yes, if only to figure out the cause of the failure conclusively. |
So,,, looking more into this, I noticed that we are installing the latest versions of node and npm but when I look at the errors we get in the slow test suit, I noticed it is reported in an older version of node: Sorry I am not very familiar with node, but is this test expected to not use the latest version of these packages? |
I'm seeing the same failure on master, fwiw. that particular tests is indeed supposed to be installing node v5.10.1. The new failure seems to be from running There's probably no reason the test needs to use any given node version, so let me try to update it in master. |
No description provided.