simplify code for e+=T2*V2 #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this code was using DGEMM to do a dot product, after transposing a 4D tensor, when the DGEMM was just transposing it back. also, an MA stack allocation was used for a scalar. automatic code generation is amazing, isn't it? :-) this change does the dot product directly, with loops, without any transposes and with no unnecessary MA allocation. Signed-off-by: Jeff Hammond <[email protected]>
jeffhammond
force-pushed
the
tce_ccsd_e_simplification
branch
from
480a0ed to
1bcd986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this code was using DGEMM to do a dot product, after transposing a 4D tensor, when the DGEMM was just transposing it back. also, an MA stack allocation was used for a scalar. automatic code generation is amazing, isn't it? :-)
this change does the dot product directly, with loops, without any transposes and with no unnecessary MA allocation.