updates from master to deal with super heavy elements #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Hammond <[email protected]>
Signed-off-by: Jeff Hammond <[email protected]>
Signed-off-by: Jeff Hammond <[email protected]>
Signed-off-by: Jeff Hammond <[email protected]>
Signed-off-by: Jeff Hammond <[email protected]>
Signed-off-by: Jeff Hammond <[email protected]>
Signed-off-by: Jeff Hammond <[email protected]>
there were 4 copies of these in geom.F. this eliminates code duplication. there are now 118 elements instead of 112. i stopped at 118 because 119 and higher do not have 2 character names and thus require more significant refactoring to support. Signed-off-by: Jeff Hammond <[email protected]>
somehow, adding celements to geomP.fh created duplicate symbols in the object files. Signed-off-by: Jeff Hammond <[email protected]>
Signed-off-by: Jeff Hammond <[email protected]>
… avoid nvfortran segfaults
since these have 3-character symbols, we add a 3-character symbol array (similar to the 1-character array special cases) and check that after the full element name and before the 2-character symbol check. we add the first 2 characters of the symbol name to the array of those, which is theoretically unsafe in the event that these are non-unique, but this won't be a problem as long as we check the full name, then the 3 char, then the 2 char. Signed-off-by: Jeff Hammond <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.