Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwjs truncating chrome args from package.json on windows #8219

Open
2 tasks done
zkrige opened this issue Sep 20, 2024 · 4 comments
Open
2 tasks done

nwjs truncating chrome args from package.json on windows #8219

zkrige opened this issue Sep 20, 2024 · 4 comments
Labels
bug has-min-repro Has a minimum reproduction

Comments

@zkrige
Copy link

zkrige commented Sep 20, 2024

Issue Type

Before opening an issue, please search and see if it has already been raised.

  • Bug Report
  • Successfully reproduced against the latest version of NW.js?

from package.json
"chromium-args": "--enable-gcm --disable-features=ProcessPerSiteUpToMainFrameThreshold --user-agent='' --enable-features=NativeNotifications --enable-chrome-browser-cloud-management --enable-speech-dispatcher --enable-logging --js-flags='--no-flush-bytecode' --disable-web-security --allow-file-access --allow-file-access-from-files --enable-experimental-web-platform-features ",

from chrome://flags
\nwjs-sdk-v0.91.0-win-x64\nw.exe" --remote-debugging-port=9222 --enable-gcm --disable-features=ProcessPerSiteUpToMainFrameThreshold --user-agent --enable-features=NativeNotifications --enable-chrome-browser-cloud-management --enable-speech-dispatcher --enable-logging --js-flags=--no-flush-bytecode --disable-web-sec�I"

this is what was causing #8218 - I had enable-gcm at the end and it was being truncated and not sent to chrome

so a couple of my chrome flags arent actually being sent to chrome - this appears to happen only on windows

@ayushmanchhabra
Copy link
Contributor

ayushmanchhabra commented Sep 21, 2024

Most likely related to #7670. Although I noticed that the character count in your repro is 284 - not sure what's going on there 👀

@zkrige
Copy link
Author

zkrige commented Sep 21, 2024

Remote debugging port isn't part of the package.json - it's a node command line parameter

The 260 limit seems to be on args set in package.JSON

@rogerwang this is currently affecting over 500 000 devices running our app

We urgently need a fix here

@zkrige
Copy link
Author

zkrige commented Sep 21, 2024

closing because duplicate of #7670

@zkrige zkrige closed this as completed Sep 21, 2024
@zkrige
Copy link
Author

zkrige commented Oct 8, 2024

Reopening this for visibility

@zkrige zkrige reopened this Oct 8, 2024
@ayushmanchhabra ayushmanchhabra added bug has-min-repro Has a minimum reproduction labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug has-min-repro Has a minimum reproduction
Projects
None yet
Development

No branches or pull requests

2 participants