Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Tree about TJA1102A #1

Open
LawKongYo opened this issue May 12, 2022 · 0 comments
Open

Device Tree about TJA1102A #1

LawKongYo opened this issue May 12, 2022 · 0 comments

Comments

@LawKongYo
Copy link

LawKongYo commented May 12, 2022

hi!
I want to bind a SJA1105 device with two TJA1102As on the eno0 port of LS1028A deivce.
There are 4 phy devices on eno0 (each TJA1102A has 2 phy address) port.
How can I add all the 4 phy-handle into the device tree node "enetc0"?
Thank you!
Looking forward to your reply!
Best wishes!

MinghuanLian pushed a commit that referenced this issue Jul 12, 2024
The driver exists two issues:
1. For RX buffer, current driver release the buffer too early, should
   wait until free_pkt callback is called. Otherwise, the released
   buffer will put into rx bd ring again and may be used by enetc when
   uboot is processing the packet.

2. The RX BD size is only 16 bytes, but cache line is 64 bytes on iMX95,
   so when flush a free RX BD to submit it ring, the flush may write
   adjacent BDs which locate in same cache line into memory. It has the
   possibility that netc has used (filled) this adjacent BD before uboot
   processes it. So the BD content is overwritten. It will cause polling
   Ready bit of this BD always failed. We already observed such issue
   in 1000Mbps network.

The patch added the free_pkt call back implementation for issue #1. And
for issue #2, it adjusts to submit BDs in cache line size to ring.
For example, on iMX95, we submit 4 RX BDs which are in one cache line.
The cache operations are also re-fined in the patch with clean codes.

Signed-off-by: Ye Li <[email protected]>
Reviewed-by: Peng Fan <[email protected]>
Acked-by: Wei Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant