-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "recent changes" box show changes from all users #745
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 88 88
Lines 3631 3631
=======================================
Hits 3436 3436
Misses 195 195 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
<li class="{% if entry.is_addition %}addlink{% endif %}{% if entry.is_change %}changelink{% endif %}{% if entry.is_deletion %}deletelink{% endif %}"> | ||
{% if entry.is_deletion or not entry.get_admin_url %} | ||
{% if entry.content_type %} | ||
{% filter capfirst %}{{ entry.content_type.name }}{% endfilter %}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permission issues with tokens, possibly others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the implication of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will defer to James if there are permissions issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this will be in addition to the personal recent edits sidebar?
<li class="{% if entry.is_addition %}addlink{% endif %}{% if entry.is_change %}changelink{% endif %}{% if entry.is_deletion %}deletelink{% endif %}"> | ||
{% if entry.is_deletion or not entry.get_admin_url %} | ||
{% if entry.content_type %} | ||
{% filter capfirst %}{{ entry.content_type.name }}{% endfilter %}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the implication of this?
Closes #740