Fully functional network scores #5048
Conversation
- add clap to agent - agent runs network probe - /submit endpoint on NS API
- task that queues testruns periodically - testruns read/write in DB
- testruns are assigned on API - submit updates testruns correctly on NS API side - agent registers with API - agent submits results correctly
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
common/bin-common/src/lib.rs
Outdated
| @@ -10,3 +10,6 @@ pub mod completions; | |||
|
|
|||
| #[cfg(feature = "output_format")] | |||
| pub mod output_format; | |||
|
|
|||
| #[cfg(feature = "models")] | |||
| pub mod models; | |||
There was a problem hiding this comment.
why did you put it in bin-common? it doesn't really feel like it belongs here. why would say nym-api or nym-client ever care about those models?
There was a problem hiding this comment.
why would say nym-api or nym-client ever care about those models?
if they don't, that's why I put it behind models
I needed a place from which both node-status-api and node-status-agent could pull a depending struct because i'd like to avoid having one of them depend on the other.
Can you show me a better place to put it?
There was a problem hiding this comment.
I'd say create another common/<something> crate, I don't want bin-common getting polluted because it's meant to be for common things shared by runnable binaries: like build information, setting up logging, etc.
There was a problem hiding this comment.
done, moved to a lib called common/models
| nym-network-defaults = { git = "https://github.com/nymtech/nym", rev = "f86e08866" } | ||
| nym-validator-client = { git = "https://github.com/nymtech/nym", rev = "f86e08866" } | ||
| # TODO dz: before Nym API client breaking changes. Update to latest develop once new Nym API is live | ||
| nym-network-defaults = { git = "https://github.com/nymtech/nym", branch = "pre-dir-v2-fork" } |
There was a problem hiding this comment.
don't we have to update it to be compatible with magura asap?
There was a problem hiding this comment.
I need to deploy this to be available for Nym VPN clients ASAP-er
There was a problem hiding this comment.
yeah, totally, I'm just wondering whether it's going to be compatible, but I guess all "old" clients (so this one would apply) should work
dynco-nym
force-pushed
the
dz-network-probe
branch
from
364fe06
to
1be2a56
Compare
* Compile & copy wg probe * Node status agent WIP * Enable debug logging * Agent submits results - add clap to agent - agent runs network probe - /submit endpoint on NS API * Build clients with timeouts * Update logging and dev scripts * Replace /blaclisted endpoint * Testruns fully functional - task that queues testruns periodically - testruns read/write in DB * Probe scores fully working - testruns are assigned on API - submit updates testruns correctly on NS API side - agent registers with API - agent submits results correctly * Clippy fixes * PR feedback * Clippy again * PR feedback * Run clippy earlier in CI * Make refresh delay configurable in server & agent
This change is