Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device state restore get handlers are never called #66

Open
jcro opened this issue Dec 23, 2024 · 1 comment
Open

Device state restore get handlers are never called #66

jcro opened this issue Dec 23, 2024 · 1 comment

Comments

@jcro
Copy link

jcro commented Dec 23, 2024

add_get sets up a get handler to be used to restore device state, adding data to tables get_fptr, get_opaque, get_size, and get_data. These tables are never referenced elsewhere, like in fdl_fast_reload, meaning a subset of device state is not restored when a snapshot is loaded. This can cause VMs to not work correctly (for example by being unresponsive) after a snapshot is restored.

@jcro
Copy link
Author

jcro commented Dec 26, 2024

There appear to be a few other related issues.

  1. fdl_fast_create_tmp calls the VMSD pre_load and post_load function pointers when creating a tmp snapshot; however this isn't necessary AFAIK. pre_load and post_load only need to be called when loading a snapshot.
  2. fdl_fast_create_tmp fails to call the VMSD pre_save function pointer when creating a tmp snapshot.
  3. fdl_fast_create_tmp fails to update get handler state when creating a tmp snapshot, so even if the get_fptr stuff mentioned above is addressed, fdl_fast_reload will just load get_fptr device state from the original root snapshot instead of from the tmp snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant