Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable WASM #296

Open
ChristopherRabotin opened this issue Apr 23, 2024 · 2 comments
Open

Reenable WASM #296

ChristopherRabotin opened this issue Apr 23, 2024 · 2 comments

Comments

@ChristopherRabotin
Copy link
Member

Maintenance task description

I just disabled WASM to update a bunch of dependencies. I also don't know how much ANISE is compatible with WASM, and that's the biggest upcoming change (it takes a lot of work).

Scope of work

Uncomment the lines in the rust.yaml github workflow, and iterate on what needs fixing.

Priority

Low

ChristopherRabotin added a commit that referenced this issue Apr 23, 2024
Will be reenabled in #296
@TilBlechschmidt
Copy link
Contributor

TilBlechschmidt commented May 6, 2024

At the very least, the core of ANISE seems to build for WASM (when excluding the metaload feature) 🙃

image

The main issue with the nyx main branch seems to be the zstd feature of parquet which attempts to build a native dependency. Disabling it does not cause a compilation failure (nyx builds successfully) but I suspect it will result in an inability to load zstd compressed files (would probably be fine for WASM).

@ChristopherRabotin
Copy link
Member Author

Interesting, thanks. It may make sense to have a wasm specific build flag then, which disables the zstd feature of parquet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants