-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace isomorphic-fetch #1908
base: main
Are you sure you want to change the base?
Replace isomorphic-fetch #1908
Conversation
Why do we need this instead of using built-in fetch? |
I agree with @mitschabaude here. We should use the built-in fetch instead of adding a dependancy. We moved to node fetch in the |
The main reason is to not drop support for node versions <18. |
I think we can do us a favor and drop that support! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should include a changelog entry for this, but otherwise LGTM!
You're right, we're dropping support for node versions <18 with the last commit, so this needs to be included in the changelog. Also, this breaks backward compatibility. Should we wait for v3 to release this PR? |
I'd consider it not breaking, and would release it under a patch version, because we have been explicit about not supporting node < 18 before:
|
I suppose we need to be more explicit about our definition of breaking. I'm inclined to agree with Gregor that we are very explicit already about node 18+ being required. As we release major versions in the future, we may want to aggressively bump that supported node version so we can continue to make changes like these. I'm ok to merge this in a minor version. Even though I see the argument that we're "dropping support", I don't think that we actually had previously "supported" those versions. They just happened to work. |
Fixes #1904
This PR replaces outdated isomorphic fetch with built-in fetch and updates the fetch examples to devnet from berkeley.