Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove account update limit for zeko #1910

Closed
youtpout opened this issue Nov 20, 2024 · 1 comment · Fixed by #1919
Closed

Remove account update limit for zeko #1910

youtpout opened this issue Nov 20, 2024 · 1 comment · Fixed by #1919

Comments

@youtpout
Copy link
Contributor

Hello,
Currently o1js has been designated for mina and relies on the current mina configuration when generating a proof to know if it will work on Mina, if the transaction is too expensive an error is returned:
Error: The transaction is too expensive, try reducing the number of AccountUpdates that are attached to the transaction.

But on zeko you don't have this kind of limit, if you want to create a proof that exceeds the number of account updates allowed by Mina, you have to modify this file:
O1js constants
and put a bigger value to COST_LIMIT.

It would be nice to have a parameter in o1js to remove this limit when you want to generate a proof for zeko.

@45930
Copy link
Contributor

45930 commented Nov 21, 2024

@youtpout this sounds like a reasonable config option. Would you want to open a PR? I think the right API would be to allow the user to define custom costs and max cost config to the Mina.Network config, so if the network is configured for zeko, verifyTransactionLimits will use different values than if it is configured for Mina.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants