Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider restricting more the env var that are being set for script execution #67

Open
andywaltlova opened this issue Mar 12, 2024 · 1 comment

Comments

@andywaltlova
Copy link
Collaborator

andywaltlova commented Mar 12, 2024

#66 introduced the fix to set all RHC_WORKER_* environment variables in the script execution. Currently the variables can get to the script only through it's yaml envelope (they are passed to the script by rhc-worker-script). The variables are in internal repository and changes are subjected to review.

It's not ideal, if someone runs the script without worker it is easy to inject some malicious variable to the runtime.

@andywaltlova
Copy link
Collaborator Author

Now env vars can also be taken from worker config, so two ways now:

  • yaml envelope containing the script
  • rhc-worker-script config, and any variables passed by rhcd to worker

But we still validate the prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant