From 888bb9f3181935bcae2f8ea7beecf0f803d2953c Mon Sep 17 00:00:00 2001 From: Michal Bocek Date: Fri, 22 Nov 2024 23:43:53 +0100 Subject: [PATCH] Make post-conversion analysis summary clearer I was not sure what "No changes needed" means (changes to do by the tool or myself?). IMHO "No action required" is clearer. --- convert2rhel/actions/__init__.py | 4 ++-- .../assessment-report/test_assessment_report.py | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/convert2rhel/actions/__init__.py b/convert2rhel/actions/__init__.py index ad2c77ef8e..880624a88a 100644 --- a/convert2rhel/actions/__init__.py +++ b/convert2rhel/actions/__init__.py @@ -81,8 +81,8 @@ #: When we print a report for the user to view, we want some explanation of #: what the results mean STATUS_HEADER = { - 0: "Success (No changes needed)", - 25: "Info (No changes needed)", + 0: "Success (No action required)", + 25: "Info (No action required)", 51: "Warning (Review and fix if needed)", 101: "Skip (Could not be checked due to other failures)", 152: "Overridable (Review and either fix or ignore the failure)", diff --git a/tests/integration/tier0/non-destructive/assessment-report/test_assessment_report.py b/tests/integration/tier0/non-destructive/assessment-report/test_assessment_report.py index 50f4239239..77dc142330 100644 --- a/tests/integration/tier0/non-destructive/assessment-report/test_assessment_report.py +++ b/tests/integration/tier0/non-destructive/assessment-report/test_assessment_report.py @@ -68,10 +68,10 @@ def test_failures_and_skips_in_report(convert2rhel): # Verify the ordering and contents # of the skip and error header # Success header first - c2r.expect_exact("Success (No changes needed)") + c2r.expect_exact("Success (No action required)") # Info header - c2r.expect_exact("Info (No changes needed)") + c2r.expect_exact("Info (No action required)") # Warning header c2r.expect_exact("Warning (Review and fix if needed)") @@ -119,7 +119,7 @@ def test_successful_report(convert2rhel): # Verify that only success header printed out, assert if error or skip header appears c2r_report_header_index = c2r.expect( - ["No changes needed", "Must fix before conversion", "Could not be checked due to other failures"], + ["No action required", "Must fix before conversion", "Could not be checked due to other failures"], timeout=300, ) if c2r_report_header_index == 0: @@ -168,7 +168,7 @@ def test_convert_method_successful_report(convert2rhel): # Verify that none of the headers is present, assert if it is present c2r_report_header_index = c2r.expect( - [EOF, "No changes needed", "Must fix before conversion", "Could not be checked due to other failures"], + [EOF, "No action required", "Must fix before conversion", "Could not be checked due to other failures"], timeout=300, ) if c2r_report_header_index == 0: