Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core.OptionalParameter/DefaultsToEmptyCollection #290

Closed

Conversation

HeikoTheissen
Copy link
Contributor

@ralfhandl ralfhandl changed the base branch from main to v4.02-release-candidate February 20, 2025 11:55
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify text

<Annotation Term="Core.LongDescription" String="If no explicit DefaultValue is specified, the service is free on how to interpret omitting the parameter from the request. For example, a service might interpret an omitted optional parameter `KeyDate` as having the current date." />
</Property>
<Property Name="NonPrimitiveDefaultValue" Type="Edm.Untyped" Nullable="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vocabulary currently uses OData 4.0, which doesn't have Edm.Untyped:

<edmx:Edmx xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx" Version="4.0">

Do we have to create a new vocabulary Org.OData.Core.V2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to create a new vocabulary Org.OData.Core.V2?

That's too heavy a tool for this small problem.

@HeikoTheissen HeikoTheissen changed the title Core.OptionalParameter/NonPrimitiveDefaultValue Core.OptionalParameter/DefaultsToEmptyCollection Feb 20, 2025
@HeikoTheissen
Copy link
Contributor Author

Not needed, as discussed in TC 2025-02-26.

@HeikoTheissen HeikoTheissen deleted the 2045/NonPrimitiveDefaultValue branch February 26, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omission of collection-valued action parameters
2 participants