Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts: What's with the solc optimizer settings? #479

Open
matevz opened this issue Jan 6, 2025 · 0 comments
Open

contracts: What's with the solc optimizer settings? #479

matevz opened this issue Jan 6, 2025 · 0 comments
Labels
contracts Pull requests that update sapphire-contracts

Comments

@matevz
Copy link
Member

matevz commented Jan 6, 2025

SUMMARY

Followup to https://github.com/oasisprotocol/sapphire-paratime/pull/477/files#r1896639760

It seems this solc optimizer snippet is required for any example that uses sapphire-contracts:

solidity: {
version: '0.8.20',
settings: {
optimizer: {
enabled: true,
runs: (1 << 32) - 1,
},
viaIR: true,
},
},

Investigate, why the optimizer setting is there in the first place. Execution speed? Security? Blame says these lines are 3 years old. Then figure out why this snippet is not required by external projects that import sapphire-contracts npm package.

COMPONENT NAME

contracts

@matevz matevz added the contracts Pull requests that update sapphire-contracts label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Pull requests that update sapphire-contracts
Projects
None yet
Development

No branches or pull requests

1 participant