Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue: import handling revamp #288

Closed
4 tasks done
obi1kenobi opened this issue Jan 12, 2023 · 1 comment · Fixed by #330
Closed
4 tasks done

Tracking issue: import handling revamp #288

obi1kenobi opened this issue Jan 12, 2023 · 1 comment · Fixed by #330
Assignees
@obi1kenobi
Labels
C-enhancement Category: raise the bar on expectations

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Jan 12, 2023 •
edited
Loading

Type alias support is more valuable than renaming re-exports, per libp2p/rust-libp2p#2647 (comment)
@obi1kenobi obi1kenobi added the C-enhancement Category: raise the bar on expectations label Jan 12, 2023
@obi1kenobi obi1kenobi self-assigned this Jan 12, 2023
@obi1kenobi
Copy link
Owner Author

Here are some of the import shenanigans we should correctly handle:
https://github.com/obi1kenobi/trustfall-rustdoc-adapter/compare/imports_test_suite

@obi1kenobi obi1kenobi mentioned this issue Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obi1kenobi obi1kenobi

Labels
C-enhancement Category: raise the bar on expectations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect and don't report non-breaking renaming re-exports. obi1kenobi/cargo-semver-checks
1 participant
@obi1kenobi