Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to Fix incorrect-package Warning #208

Closed
volodya-lombrozo opened this issue Jan 9, 2025 · 6 comments
Closed

Impossible to Fix incorrect-package Warning #208

volodya-lombrozo opened this issue Jan 9, 2025 · 6 comments
Labels
bug Something isn't working

Comments

@volodya-lombrozo
Copy link
Member

I'm getting the following warning when I check my xmir:

[incorrect-package WARNING]:0 The format of the +package meta is wrong: "j$org.j$eolang.j$jeo"

I have the meta:

...
<metas>
      <meta>
         <head>package</head>
         <tail>j$org.j$eolang.j$jeo</tail>
         <part>j$org.j$eolang.j$jeo</part>
      </meta>
</metas>
...

There is how I check the xmir:

final Collection < Defect > defects = new Program(new StrictXmir(this.doc)).defects()
    .stream()
    .collect(Collectors.toList());
if (!defects.isEmpty()) {
    throw new IllegalStateException(
        String.format(
            "XMIR is incorrect: %s, %n%s%n",
            defects,
            this.doc
        )
    );
}

Full xmir:
MethodByte.xmir.txt

The package is perfectly fine. Please remove this check or provide a more human-readable explanation of what needs to be done to fix the issue (directly in the error message.)
@volodya-lombrozo
Copy link
Member Author

Blocks: objectionary/jeo-maven-plugin#946

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you take a look, please?

@yegor256 yegor256 added the bug Something isn't working label Jan 9, 2025
@yegor256
Copy link
Member

yegor256 commented Jan 9, 2025

@h1alexbel this indeed is a bug, can you please help?

@h1alexbel
Copy link
Contributor

@yegor256 yes

h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 9, 2025
@h1alexbel
bug(objectionary#208): accepts dollar sign
a7be037
@h1alexbel h1alexbel mentioned this issue Jan 9, 2025
Merged
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 9, 2025
@h1alexbel
bug(objectionary#208): trigger
525bbfc
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 9, 2025
@h1alexbel
bug(objectionary#208): back
eeb0f53
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 10, 2025
@h1alexbel
bug(objectionary#208): allows fqn
9afdb96
h1alexbel added a commit to h1alexbel/lints that referenced this issue Jan 10, 2025
@h1alexbel
bug(objectionary#208): clean for xcop
c5f1c39
yegor256 added a commit that referenced this issue Jan 10, 2025
@yegor256
Merge pull request #211 from h1alexbel/208
dd3969f 
bug(#208): incorrect-package accepts `fqn`
@h1alexbel
Copy link
Contributor

@volodya-lombrozo still an issue?

@volodya-lombrozo
Copy link
Member Author

@h1alexbel This one is fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @volodya-lombrozo @h1alexbel