From 1bf96b1fc8c5de457a16df6fbd2ebd64e1000dc9 Mon Sep 17 00:00:00 2001
From: Daishan Peng <StrongMonkey@users.noreply.github.com>
Date: Fri, 1 Nov 2024 15:56:18 -0700
Subject: [PATCH] Chore: Add knowledge description, enforce unique urls (#416)

Signed-off-by: Daishan Peng <daishan@acorn.io>
---
 ui/admin/app/components/agent/Agent.tsx       |  6 +++-
 .../knowledge/AgentKnowledgePanel.tsx         | 35 ++++++++++++++++++-
 .../knowledge/onedrive/AddLinkModal.tsx       | 10 +++---
 .../knowledge/website/AddWebsiteModal.tsx     | 10 +++---
 .../knowledge/website/WebsiteModal.tsx        |  2 +-
 ui/admin/app/lib/model/agents.ts              |  2 +-
 6 files changed, 53 insertions(+), 12 deletions(-)

diff --git a/ui/admin/app/components/agent/Agent.tsx b/ui/admin/app/components/agent/Agent.tsx
index 6d700a0e3..4c093e846 100644
--- a/ui/admin/app/components/agent/Agent.tsx
+++ b/ui/admin/app/components/agent/Agent.tsx
@@ -89,7 +89,11 @@ function AgentContent({ className, onRefresh }: AgentProps) {
                         website, or external links in order to give it context
                         about various topics.
                     </TypographyP>
-                    <AgentKnowledgePanel agentId={agent.id} />
+                    <AgentKnowledgePanel
+                        agentId={agent.id}
+                        agent={agent}
+                        updateAgent={debouncedSetAgentInfo}
+                    />
                 </div>
             </ScrollArea>
 
diff --git a/ui/admin/app/components/knowledge/AgentKnowledgePanel.tsx b/ui/admin/app/components/knowledge/AgentKnowledgePanel.tsx
index 29ea36bd5..4e8d65277 100644
--- a/ui/admin/app/components/knowledge/AgentKnowledgePanel.tsx
+++ b/ui/admin/app/components/knowledge/AgentKnowledgePanel.tsx
@@ -2,6 +2,7 @@ import { Globe, SettingsIcon, UploadIcon } from "lucide-react";
 import { useEffect, useMemo, useState } from "react";
 import useSWR, { SWRResponse } from "swr";
 
+import { Agent } from "~/lib/model/agents";
 import {
     KnowledgeFile,
     KnowledgeFileState,
@@ -13,12 +14,24 @@ import { assetUrl } from "~/lib/utils";
 import { Button } from "~/components/ui/button";
 
 import { Avatar } from "../ui/avatar";
+import { Label } from "../ui/label";
+import { Textarea } from "../ui/textarea";
 import FileModal from "./file/FileModal";
 import { NotionModal } from "./notion/NotionModal";
 import { OnedriveModal } from "./onedrive/OneDriveModal";
 import { WebsiteModal } from "./website/WebsiteModal";
 
-export default function AgentKnowledgePanel({ agentId }: { agentId: string }) {
+type AgentKnowledgePanelProps = {
+    agentId: string;
+    agent: Agent;
+    updateAgent: (updatedAgent: Agent) => void;
+};
+
+export default function AgentKnowledgePanel({
+    agentId,
+    agent,
+    updateAgent,
+}: AgentKnowledgePanelProps) {
     const [blockPollingLocalFiles, setBlockPollingLocalFiles] = useState(false);
     const [blockPollingOneDrive, setBlockPollingOneDrive] = useState(false);
     const [blockPollingNotion, setBlockPollingNotion] = useState(false);
@@ -34,6 +47,10 @@ export default function AgentKnowledgePanel({ agentId }: { agentId: string }) {
     const [isNotionModalOpen, setIsNotionModalOpen] = useState(false);
     const [isWebsiteModalOpen, setIsWebsiteModalOpen] = useState(false);
 
+    const [knowledgeDescription, setKnowledgeDescription] = useState(
+        agent.knowledgeDescription
+    );
+
     const getLocalFiles: SWRResponse<KnowledgeFile[], Error> = useSWR(
         KnowledgeService.getLocalKnowledgeFilesForAgent.key(agentId),
         ({ agentId }) =>
@@ -347,6 +364,22 @@ export default function AgentKnowledgePanel({ agentId }: { agentId: string }) {
 
     return (
         <div className="flex flex-col gap-4 justify-center items-center">
+            <div className="grid w-full gap-2">
+                <Label htmlFor="message">Knowledge Description</Label>
+                <Textarea
+                    placeholder="Provide a brief description of the information contained in this knowledge base. Example: A collection of documents about the human resources policies and procedures for Acme Corporation."
+                    id="message"
+                    value={knowledgeDescription ?? ""}
+                    onChange={(e: React.ChangeEvent<HTMLTextAreaElement>) => {
+                        setKnowledgeDescription(e.target.value);
+                        updateAgent({
+                            ...agent,
+                            knowledgeDescription: e.target.value,
+                        });
+                    }}
+                />
+            </div>
+
             <div className="flex w-full items-center justify-between gap-3 rounded-md bg-background px-3 py-2 text-sm font-semibold text-gray-900 shadow-sm ring-1 ring-inset ring-muted-foreground/20 focus-visible:ring-transparent">
                 <div className="flex items-center gap-2 text-foreground">
                     <UploadIcon className="h-5 w-5" />
diff --git a/ui/admin/app/components/knowledge/onedrive/AddLinkModal.tsx b/ui/admin/app/components/knowledge/onedrive/AddLinkModal.tsx
index 51b8ddf20..e33194f29 100644
--- a/ui/admin/app/components/knowledge/onedrive/AddLinkModal.tsx
+++ b/ui/admin/app/components/knowledge/onedrive/AddLinkModal.tsx
@@ -35,7 +35,7 @@ const AddLinkModal: FC<AddLinkModalProps> = ({
         if (!knowledgeSource) {
             await KnowledgeService.createKnowledgeSource(agentId, {
                 onedriveConfig: {
-                    sharedLinks: [newLink],
+                    sharedLinks: [newLink.trim()],
                 },
             });
         } else {
@@ -46,9 +46,11 @@ const AddLinkModal: FC<AddLinkModalProps> = ({
                     ...knowledgeSource,
                     onedriveConfig: {
                         sharedLinks: [
-                            ...(knowledgeSource.onedriveConfig?.sharedLinks ||
-                                []),
-                            newLink,
+                            ...(
+                                knowledgeSource.onedriveConfig?.sharedLinks ||
+                                []
+                            ).filter((url) => url !== newLink.trim()),
+                            newLink.trim(),
                         ],
                     },
                 }
diff --git a/ui/admin/app/components/knowledge/website/AddWebsiteModal.tsx b/ui/admin/app/components/knowledge/website/AddWebsiteModal.tsx
index eb5aca3ca..c0f343756 100644
--- a/ui/admin/app/components/knowledge/website/AddWebsiteModal.tsx
+++ b/ui/admin/app/components/knowledge/website/AddWebsiteModal.tsx
@@ -30,8 +30,8 @@ const AddWebsiteModal: FC<AddWebsiteModalProps> = ({
             const formattedWebsite =
                 newWebsite.startsWith("http://") ||
                 newWebsite.startsWith("https://")
-                    ? newWebsite
-                    : `https://${newWebsite}`;
+                    ? newWebsite.trim()
+                    : `https://${newWebsite.trim()}`;
 
             if (!knowledgeSource) {
                 await KnowledgeService.createKnowledgeSource(agentId, {
@@ -47,8 +47,10 @@ const AddWebsiteModal: FC<AddWebsiteModalProps> = ({
                         ...knowledgeSource,
                         websiteCrawlingConfig: {
                             urls: [
-                                ...(knowledgeSource.websiteCrawlingConfig
-                                    ?.urls || []),
+                                ...(
+                                    knowledgeSource.websiteCrawlingConfig
+                                        ?.urls || []
+                                ).filter((url) => url !== formattedWebsite),
                                 formattedWebsite,
                             ],
                         },
diff --git a/ui/admin/app/components/knowledge/website/WebsiteModal.tsx b/ui/admin/app/components/knowledge/website/WebsiteModal.tsx
index 82840bc67..f9befaa5e 100644
--- a/ui/admin/app/components/knowledge/website/WebsiteModal.tsx
+++ b/ui/admin/app/components/knowledge/website/WebsiteModal.tsx
@@ -264,7 +264,7 @@ export const WebsiteModal: FC<WebsiteModalProps> = ({
                                             <RemoteFileItemChip
                                                 key={item.fileName}
                                                 file={item}
-                                                fileName={item.fileName}
+                                                fileName={item.url}
                                                 knowledgeSourceType={
                                                     RemoteKnowledgeSourceType.Website
                                                 }
diff --git a/ui/admin/app/lib/model/agents.ts b/ui/admin/app/lib/model/agents.ts
index 86bd3d43c..a240207da 100644
--- a/ui/admin/app/lib/model/agents.ts
+++ b/ui/admin/app/lib/model/agents.ts
@@ -13,7 +13,7 @@ export type AgentBase = {
     workflows?: string[];
     tools?: string[];
     params?: Record<string, string>;
-    knowledgeSetStatues: KnowledgeSetStatus[];
+    knowledgeDescription?: string;
 };
 
 export type KnowledgeSetStatus = {