some opinionated layout changes to match other docs #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Oct 12, 2024
There was a problem hiding this comment.
Appreciate the contribution but I’m going to wait on this a bit to decide how I feel. I don’t think I want to tie us pixel-perfect to the VitePress layout, or that I like the VitePress layout better than ours, and I’m not sure about the effort to make all the sites match exactly.
|
Understood. Should I change this to a draft for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching between the Framework site and the Plot site, there are a few small layout differences, and it would be nice to make them consistent. Changes in this PR:
See videos below.
Desktop
Screen.Recording.2024-10-11.at.4.37.17.PM.mov
Mobile
Screen.Recording.2024-10-11.at.4.44.16.PM.mov