Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs edits #792

Merged
merged 19 commits into from
Feb 14, 2024
Merged

inputs edits #792

merged 19 commits into from
Feb 14, 2024

Conversation

mbostock
Copy link
Member

This…

  • Changes the inputs page to focus more on the concept of inputs, and less on Observable Inputs
  • Adds an example of using Observable Plot as an input!
  • Describes when to use Generators.input apart from view
  • Moves the overview (usage) of Observable Inputs to the Observable Inputs page (/lib/inputs)

Still to-do:

  • Trim the Observable Inputs page (and fix errors I introduced)
  • Add something to the individual inputs pages that ties them more strongly to Observable Inputs

@mbostock mbostock requested review from Fil and allisonhorst February 14, 2024 16:31
@allisonhorst

This comment was marked as resolved.

@mbostock mbostock force-pushed the mbostock/more-inputs branch from c7af7af to cc54f0c Compare February 14, 2024 20:10
@Fil
Copy link
Contributor

Fil commented Feb 14, 2024

looking good so far!

@mbostock mbostock marked this pull request as ready for review February 14, 2024 20:49
@mbostock mbostock enabled auto-merge (squash) February 14, 2024 22:11
Copy link
Contributor

@allisonhorst allisonhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mbostock mbostock merged commit 4f654b4 into main Feb 14, 2024
2 checks passed
@mbostock mbostock deleted the mbostock/more-inputs branch February 14, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants