Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A map transform that makes z interval-aware #1846

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Sep 1, 2023

TODO: This should probably go in the map.js section, together with a specific option that we'd pass to the map transform?

closes #1842

@Fil Fil requested a review from mbostock September 1, 2023 06:03
@mbostock
Copy link
Member

mbostock commented Sep 1, 2023

I think this should be solved by the map transform rather than by the box mark.

@Fil
Copy link
Contributor Author

Fil commented Sep 4, 2023

To pass the information that "z must be intervaled with the y scale", we can test whether options.z===options.y, which is simple (2c61dda).

Before that I tried to pass something like "z.scale = 'y'" to make it more specific, but my solution used ChannelValueSpec, which was wrong typewise; here z is a ChannelValue, and this type doesn't support scale hints. If we had a way to specify a scale on a ChannelValue, or if z could be a ChannelValueSpec, this behavior would be better defined.

@Fil
Copy link
Contributor Author

Fil commented Sep 14, 2023

I realize this issue was already mentioned in #1330 (comment)!

@Fil Fil changed the title A transform that makes z interval-aware A map transform that makes z interval-aware Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The map transform should maybe apply maybeApplyInterval?
2 participants