Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: add support for distinguishing hover & click events #1979

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Experiment: add support for distinguishing hover & click events #1979

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b9e91cd
prototype support for distinguishing hover & click events via the Cus…
yurivish Jan 30, 2024
cd5988f
dispatch a subclass of Event with a sticky option
yurivish Jan 31, 2024
3687112
move the StickyEvent definition inside the `plot` function
yurivish Jan 31, 2024
ca18ec3
fix formatting
yurivish Jan 31, 2024
73a0e67
let's see what happens if we move the event back out to the top level…
yurivish Jan 31, 2024
411a6ce
Revert "let's see what happens if we move the event back out to the t…
yurivish Jan 31, 2024
9ce5bc4
store sticky state in a context field rather than on the figure element
yurivish Feb 5, 2024
2ff8a1b
add an interactive test for sticky pointers which displays the clicke…
yurivish Feb 5, 2024
b53c9e8
rearrange comment
yurivish Feb 5, 2024
57ed10e
manually generate desired output html for snapshot test
yurivish Feb 5, 2024
91000aa
align output formatting with the pointerViewof test
yurivish Feb 5, 2024
138b917
remove explicit initialization of context.stickyState
yurivish Feb 5, 2024
615ff94
prettier
yurivish Feb 6, 2024
02023a9
add generated snapshot test
yurivish Feb 6, 2024
4e7b2dd
move sticky event to to the outside of the `plot` function
yurivish Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/interactions/pointer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function pointerK(kx, ky, {x, y, px, py, maxRadius = 40, channels, render, ...op

// Dispatch the value. When simultaneously exiting this facet and
// entering a new one, prioritize the entering facet.
if (!(i == null && facetState?.size > 1)) context.dispatchValue(i == null ? null : data[i]);
if (!(i == null && facetState?.size > 1)) context.dispatchValue(i == null ? null : data[i], s);
return r;
}

Expand Down
7 changes: 4 additions & 3 deletions src/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,11 @@ export function plot(options = {}) {
};

// Allows e.g. the pointer transform to support viewof.
context.dispatchValue = (value) => {
if (figure.value === value) return;
context.dispatchValue = (value, detail) => {
if (figure.value === value && figure._detail === detail) return;
figure.value = value;
figure.dispatchEvent(new Event("input", {bubbles: true}));
figure._detail = detail;
figure.dispatchEvent(new CustomEvent("input", {bubbles: true, detail}));
};

// Reinitialize; for deriving channels dependent on other channels.
Expand Down
Loading