Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration fails for tables without a primary key #25

Open
mightybyte opened this issue Jul 27, 2021 · 0 comments
Open

Migration fails for tables without a primary key #25

mightybyte opened this issue Jul 27, 2021 · 0 comments

Comments

@mightybyte
Copy link
Contributor

For tables without a primary key, beam-automigrate tries to run the following SQL:

ALTER TABLE my_table ADD CONSTRAINT my_table_pkey PRIMARY KEY ();

This is invalid SQL because there is nothing in the parentheses, so the migration fails.
mightybyte added a commit to mightybyte/beam-automigrate that referenced this issue Jul 28, 2021
@mightybyte
Handle tables without a primary key
0fd33d6 
Fixes issue obsidiansystems#25
mightybyte added a commit to mightybyte/beam-automigrate that referenced this issue Jul 28, 2021
@mightybyte
Don't try to add primary keys when there are none
2935a62 
Fixes issue obsidiansystems#25
@mightybyte mightybyte mentioned this issue Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mightybyte