Add a qcheck upper bound for preface.1.0.0 #27473
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preface.1.0.0
is incompatible withqcheck.0.24
as observed in #27468. This PR therefore adds an upper bound.In more detail:
qcheck.0.24
adding missingresult
combinators in c-cube/qcheck#308 which cause a signature clash with the handwrittenresult
combinator already present inpreface.1.0.0
https://github.com/xvw/preface/blob/b7f5210830b7916033c56ede6108c2c439c31cdf/test/preface_qcheck/gen.ml#L66-L68 and thus resulting in the error message:
To confirm that this PR indeed fixes the above, I'll be happy to wait and rebase it on
master
once #27468 is merged.