[new release] ppx_heml (0.1.0) #26297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: * Initial release
|
Seems like the only error left is "Possible conflict with |
shonfeder
requested changes
Jul 27, 2024
There was a problem hiding this comment.
Thank you for publishing this package! It looks quite useful :)
Seems like the only error left is "Possible conflict with
ppx_hereandppx_demo" 🤷♂️
Those are not an issue (and rather indicate our conflict checking is still too coarse).
Just two small changes requested to get it in great shape, afaict.
| maintainer: ["Petri-Johan Last"] | ||
| authors: ["Petri-Johan Last"] | ||
| license: "MIT" | ||
| tags: ["topics" "to describe" "your" "project"] |
There was a problem hiding this comment.
Would you either remove the tags or change them to be relevant?
| opam-version: "2.0" | ||
| synopsis: "PPX for deriving HTML templates" | ||
| description: "PPX for deriving HTML templates. Includes %heml" | ||
| maintainer: ["Petri-Johan Last"] |
There was a problem hiding this comment.
Could you provide a contact for maintenance? An email address is what we usually use and is preferable, but it should be some way you can be contacted at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPX for deriving HTML templates
CHANGES: