Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced calls to solve() #41

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Reduced calls to solve() #41

merged 2 commits into from
Mar 26, 2024

Conversation

wleoncio
Copy link
Member

Inspired by the conversation started by #17 (comment), I've moved one call of solve() on admm_MADMMplasso() (legacy code) up one loop level. Computation savings aren't huge (5%, see below), but it's something.

MADMMplasso version 0.0.0.9016
Unit: seconds
          expr    min       lq     mean   median       uq      max neval
 MADMMplasso() 82.921 83.98975 89.64103 86.89477 93.31642 108.8523    10

MADMMplasso version 0.0.0.9017
Unit: seconds
          expr      min       lq    mean   median       uq      max neval
 MADMMplasso() 79.06337 80.83594 88.9196 88.10198 94.51792 111.9471    10

To reproduce, use this script, remembering to update the path to the dataset (CRC_data_300.rds).

@wleoncio wleoncio added the enhancement New feature or request label Mar 20, 2024
@wleoncio wleoncio requested a review from Theo-qua March 20, 2024 10:34
@Theo-qua Theo-qua merged commit dca38ae into main Mar 26, 2024
7 checks passed
@wleoncio wleoncio deleted the avoid-solve branch May 22, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants