Modify the URL class by replacing the text attribute with the src_url attribute. #506
pagbabian-splunk
started this conversation in
Proposals
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The current URL object uses an attribute
text
of type URL String. This attribute name is very general for being typed as URL String, and wouldn't be useful in other classes, as for example thevalue
attribute as String is reused. Therefore, it makes more sense to removetext
as URL String from the dictionary if it isn't used elsewhere (so far it is not), and replace it withsrc_url
which has been re-typed as URL String.This would change references to the
url
attribute fromurl.text
tourl.src_url
the downside of which is a somewhat redundant descriptive name.url.value
would have been more accurate but thevalue
attribute is generic and of type String, not URL String, so could fail validation.Note that this breaks any current implementation usage.
2 votes ·
Beta Was this translation helpful? Give feedback.
All reactions