IMDb update #686
Merged
IMDb update #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a writer not having 'attributes'. Update the hash used to retrieve the storyline. Recognise a review might not contain a rating.
Even with the updated hash getting the TMD data still sometimes failed. It even failed on the website, which showed me an alternative way to get the data.
Add the videos provided by IMDb to the context menu. If subtitles are
available they will be shown as additional indented language entries.
E.g.
Trailer (1:23)
English
Selecting the first will play without subtitles, selecting the second
will play with English subtitles.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
attributeserror (closes #683); recognises a review without a rating; fixes and improves getting the storyline; adds IMDb videos to the context menu.