Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: do plugin universal css agnostic #10

Open
2 of 6 tasks
reslear opened this issue Jul 29, 2021 · 1 comment
Open
2 of 6 tasks

refactor: do plugin universal css agnostic #10

reslear opened this issue Jul 29, 2021 · 1 comment

Comments

@reslear
Copy link
Contributor

reslear commented Jul 29, 2021

hi @lilianjin, i'm suggest do plugin css agnostic:

  • remove tailwind classes from plugin
  • add specific plugin classes like (sc-container, sc-wrapper, sc-input etc...)
  • add styles to .css for vanilla css (compiled with tailwind) and importing if need [1]
  • add to package.json separate exports for css files
  • add instruction how to use with tailwind and well-now classes with @apply syntax [2]
  • rewrite to typescript

[1]

// importing styles if need css 
import 'ofcold-security-code/styles.css'
.sc-container {
   display:flex;
   margin-left: auto;
   margin-right: auto;
}

[2]

.sc-container {
   @apply flex flex-direction ml-auto mr-auto
}
@reslear reslear changed the title feat: remove tailwind refactor: do plugin css agnostic Jul 29, 2021
@reslear reslear changed the title refactor: do plugin css agnostic refactor: do plugin universal css agnostic Jul 29, 2021
@lilianjin
Copy link
Contributor

Thank you for your excellent proposal!
I will finish it in some time, and I have other things busy recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants