Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fabtests/CI: Add coverage to validate fi_info returned with FI_CONNREQ #7303

Closed
shefty opened this issue Dec 10, 2021 · 1 comment
Closed

fabtests/CI: Add coverage to validate fi_info returned with FI_CONNREQ #7303

shefty opened this issue Dec 10, 2021 · 1 comment
Labels
enhancement fabtests/CI

Comments

@shefty
Copy link
Member

shefty commented Dec 10, 2021

For background, see #7300.

The fi_getinfo_test will validate the fi_info structure returned by calling fi_getinfo. However, there's a second way for apps to obtain an fi_info structure, which is when handling an FI_CONNREQ event. There are no tests that validate such an fi_info
structure is correct. For example, in #7300, the problem is that the returned fabric_attr::prov_name and abi_version fields were not set. This was an existing issue which a recent change happened to expose.
@Juee14Desai
Copy link
Contributor

This issue is resolved by PR #9355 which has been merged recently. This issue can be closed.

@shefty shefty closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement fabtests/CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shefty @Juee14Desai