-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prov/shm: Re-enable ze-ipc with new pidfd method #10256
Merged
Merged
+234
−480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdworkin
force-pushed
the
ze-shm
branch
3 times, most recently
from
August 1, 2024 16:30
faa05be
to
b8c58ca
Compare
j-xiong
reviewed
Aug 1, 2024
j-xiong
reviewed
Aug 1, 2024
j-xiong
reviewed
Aug 1, 2024
zachdworkin
force-pushed
the
ze-shm
branch
2 times, most recently
from
August 2, 2024 16:11
cfcee28
to
bfbc5a7
Compare
j-xiong
reviewed
Aug 2, 2024
j-xiong
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more comment.
j-xiong
approved these changes
Aug 2, 2024
I will re-run ci after updates from #10272 are done. |
aingerson
reviewed
Aug 2, 2024
zachdworkin
force-pushed
the
ze-shm
branch
5 times, most recently
from
August 2, 2024 19:08
ceb170c
to
e4b8709
Compare
aingerson
reviewed
Aug 2, 2024
Add a void **handle to close_handle for level-zero to use in its new ipc protocol Signed-off-by: Zach Dworkin <zachary.dworkin@intel.com>
Move away from using a socket to initialize level-zero ipc by path and start using pidfd instead. This new protocol will open the pidfd (process id's fd containing all open fd's for that process) for a peer and save it in their region. This is done to avoid multiple open/close calls on the same fd. We then use this pidfd to lookup each open fd from level-zero's open_handle and cache them for later re-use. These are stored as a new data type "ze_pid_handle" which contains the fd from handle_get, the fd from handle_open, and the pid_fd. When a cache entry is evicted then the handle's open fds will be closed. These changes re-enable the level-zero ipc protocol. Signed-off-by: Zach Dworkin <zachary.dworkin@intel.com>
aingerson
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor close_handle to add new field for ze pidfd method
Implement ze pidfd method for ze-ipc copies
Remove old method's (socket by path) code