contrib/aws: add coverage for Amazon Linux 2023 #10273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wenduwan can we move tcp/sockets to non-efa instances? they don't need it, right? |
|
@shijin-aws I forgot but did we have a special reason to use hpc6a before? I don't think we need EFA either. |
|
I don't think there is a special reason, probably because the yaml config enables EFA by default and if you use an non-efa instance you need to pass additional cmd line args |
Amazon Linux 2023 has 6.x kernel which is not covered in CI. Also test tcp/socket providers on non-EFA platforms to conserve capacity. Signed-off-by: Wenduo Wang <[email protected]>
wenduwan
force-pushed
the
aws_ci_kernel6
branch
from
e30bc48 to
69c34cd
Compare
|
@shijin-aws Cool. Switched to c6g instead. Could you kick off CI? I don't have permission to run this change. |
I don't understand, shouldn't your PR trigger the new test as is? |
|
It does not. |
|
Then how your earlier push go through AWS CI? |
|
bot:aws:retest |
2 similar comments
|
bot:aws:retest |
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon Linux 2023 has 6.x kernel which is not covered in CI.
As a result we will consume more hpc6a capacity. To avoid capacity issues, switch tcp/socket tests to a more abundant instance type, e.g. c6gn.16xlarge.