Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper Error handling in Patient Registration Form #10555

Closed
rajku-dev opened this issue Feb 11, 2025 · 5 comments · Fixed by #10581
Closed

Improper Error handling in Patient Registration Form #10555

rajku-dev opened this issue Feb 11, 2025 · 5 comments · Fixed by #10581
Assignees
Labels
needs-triage question Further information is requested

Comments

@rajku-dev
Copy link
Contributor

rajku-dev commented Feb 11, 2025

Describe the bug

  • User is unable to edit a Patient's age which is below 9 to any other age below 9, only possible using PgDn/PgUp key

Click here to reproduce.

Image

  • Prevent negative Y.O.B values to display on UI

Image

  • 'invalid uuid' could be made more user-friendly

Image

To Reproduce
Steps to reproduce the behavior:

  1. Go to Encounters > Click on Any Patient > Patient details > Edit > Scroll Down to Age Section

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@rajku-dev
Copy link
Contributor Author

I would like to solve this issue.

@tellmeY18 tellmeY18 added this to Care Feb 11, 2025
@tellmeY18 tellmeY18 moved this to Triage in Care Feb 11, 2025
@Jacobjeevan
Copy link
Contributor

(1) I am not sure I understand the issue - I am able to edit/save patient's age < 9.
(2) 👍
(3) Edit forms; form will be dirty, so we do want to show the alert. Currently, it does showup for submit as well, #10415 addresses that.

@tellmeY18 tellmeY18 moved this from Triage to In Progress in Care Feb 11, 2025
@rajku-dev
Copy link
Contributor Author

rajku-dev commented Feb 11, 2025

(1) I am not sure I understand the issue - I am able to edit/save patient's age < 9. (2) 👍 (3) Edit forms; form will be dirty, so we do want to show the alert. Currently, it does showup for submit as well, #10415 addresses that.

  • Try converting 6 to 4 or anything below 9
  • We need to show alert only when Edit forms are dirty right, not when user just navigates (to check full details) and comes back without making any changes

@github-actions github-actions bot added needs-triage question Further information is requested labels Feb 11, 2025
@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Feb 11, 2025

(1) I am not sure I understand the issue - I am able to edit/save patient's age < 9. (2) 👍 (3) Edit forms; form will be dirty, so we do want to show the alert. Currently, it does showup for submit as well, #10415 addresses that.

* Try converting 6 to 4 or anything below 9

* We need to show alert only when Edit forms are dirty right, not when user just navigates (to check full details) and comes back without making any changes
  • Ah I see. Check the backspace behavior as well, weird.
  • No, current behavior is fine 👍

@rajku-dev
Copy link
Contributor Author

rajku-dev commented Feb 11, 2025

  • Ah I see. Check the backspace behavior as well, weird.
  • No, current behavior is fine 👍

Updated the issue description for more clarity 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage question Further information is requested
Projects
Status: Done
2 participants