Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid notifications while joining #2660

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Avoid notifications while joining #2660

merged 3 commits into from
Feb 25, 2025
+14 −0

Conversation

corrideat
Copy link
Member

Closes #2629

@corrideat corrideat self-assigned this Feb 23, 2025
@corrideat
Copy link
Member Author

It turns out the solution was quite straightforward as you thought it'd be, @taoeffect.

I'm not using 'joining' as the criterion because it's ambiguous and likely wrong. For example, you get the notification sound when using a new device, even though you shouldn't.

@cypress Cypress
Copy link

cypress bot commented Feb 23, 2025 •
edited
Loading

group-income    Run #4097

Run Properties:  status check passed Passed #4097  •  git commit 9e75102d95 ℹ️: Merge c136b1625001b4fbce670768888d6b2c2bd5a48a into 78bd36675abfed0924d9f577b40f...
Project group-income
Branch Review 2629-dont-post-chat-notifications-when-joining-a-group
Run status status check passed Passed #4097
Run duration 11m 20s
Commit git commit 9e75102d95 ℹ️: Merge c136b1625001b4fbce670768888d6b2c2bd5a48a into 78bd36675abfed0924d9f577b40f...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 114
View all changes introduced in this branch ↗︎

taoeffect
taoeffect requested changes Feb 23, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ready!

@taoeffect taoeffect mentioned this pull request Feb 23, 2025
Closed
@corrideat corrideat marked this pull request as draft February 23, 2025 20:09
@corrideat corrideat marked this pull request as ready for review February 25, 2025 19:17
taoeffect
taoeffect approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see firstSync being used! 😄

@taoeffect taoeffect merged commit 6243dcf into master Feb 25, 2025
4 checks passed
@taoeffect taoeffect deleted the 2629-dont-post-chat-notifications-when-joining-a-group branch February 25, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@corrideat corrideat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't post chat notifications when joining a group
2 participants
@corrideat @taoeffect