Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup icon for current theme? #15

Open
MatthiasGrandl opened this issue Mar 17, 2024 · 2 comments · May be fixed by #17
Open

Lookup icon for current theme? #15

MatthiasGrandl opened this issue Mar 17, 2024 · 2 comments · May be fixed by #17

Comments

@MatthiasGrandl
Copy link

Any chance API for looking up icons based on the current theme could be added? I guess it's probably out of scope for this crate as getting the active theme presumably pulls in a lot of other dependencies, but it would be very handy :)

@oknozor
Copy link
Owner

oknozor commented Mar 18, 2024

Hey @MatthiasGrandl, there is no such thing as current theme for all linux desktop environment. Some may choose to use the GTK default like Gnome, some like KDE have there own configuration and some other DE like i3, sway, hypr don't even have the concept of a current theme.

That said if you want to, it would be ok to open a PR adding a function to lookup the current GTK theme. I would rather have this behind a feature flag.

Also I don't have the time to implement that myself, but PRs are welcome.

@MatthiasGrandl
Copy link
Author

Ah yeah that's true. So it seems in onagre you just have it as theme option, instead of trying to determine whatever theme is in use by the environment?

i3, sway, hypr don't even have the concept of a current theme.

well that's not quite true. you usually have some environment configuration that tells GTK/QT apps which theme to use. So I was thinking using GTK crates one could probably figure out what theme to use, with the caveat of pulling in tons of dependencies.

Also I don't have the time to implement that myself, but PRs are welcome.

I'll look into it, although I am not on Linux myself at the moment. I am building Loungy which is mostly on MacOS, but slowly getting ported to Linux :)

@joshuamegnauth54 joshuamegnauth54 linked a pull request Apr 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants