From ffc96b104865162ad30e03fc8bf49467a91dbff6 Mon Sep 17 00:00:00 2001 From: Oksana Miazina Date: Mon, 6 May 2024 16:39:05 +0300 Subject: [PATCH] style: fix checkstyle --- .../mate/academy/bookstore/controller/BookController.java | 4 ++-- .../java/mate/academy/bookstore/response/ErrorResponse.java | 2 +- .../mate/academy/bookstore/response/GeneralResponse.java | 6 +++--- .../mate/academy/bookstore/response/SuccessResponse.java | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/main/java/mate/academy/bookstore/controller/BookController.java b/src/main/java/mate/academy/bookstore/controller/BookController.java index e868ccf..c4de1fb 100644 --- a/src/main/java/mate/academy/bookstore/controller/BookController.java +++ b/src/main/java/mate/academy/bookstore/controller/BookController.java @@ -20,7 +20,6 @@ import org.springframework.web.bind.annotation.ResponseStatus; import org.springframework.web.bind.annotation.RestController; - @RestController @RequestMapping("/api/books") @AllArgsConstructor @@ -40,7 +39,8 @@ public ResponseEntity> getBookById(@PathVariable Long i } @PostMapping - public ResponseEntity> createBook(@Valid @RequestBody BookRequestDto bookDto) { + public ResponseEntity> createBook( + @Valid @RequestBody BookRequestDto bookDto) { return ResponseHandler.getSuccessResponse( bookService.save(bookDto), HttpStatus.CREATED); diff --git a/src/main/java/mate/academy/bookstore/response/ErrorResponse.java b/src/main/java/mate/academy/bookstore/response/ErrorResponse.java index 1da1bfd..7a7f9c2 100644 --- a/src/main/java/mate/academy/bookstore/response/ErrorResponse.java +++ b/src/main/java/mate/academy/bookstore/response/ErrorResponse.java @@ -6,7 +6,7 @@ @Getter public class ErrorResponse extends GeneralResponse { - private List errors; + private final List errors; public record Message(String field, String message) { } diff --git a/src/main/java/mate/academy/bookstore/response/GeneralResponse.java b/src/main/java/mate/academy/bookstore/response/GeneralResponse.java index 11e8831..bc24c38 100644 --- a/src/main/java/mate/academy/bookstore/response/GeneralResponse.java +++ b/src/main/java/mate/academy/bookstore/response/GeneralResponse.java @@ -7,11 +7,11 @@ @Getter public abstract class GeneralResponse { - private boolean success; - private int status; + private final boolean success; + private final int status; @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "dd-MM-yyyy hh:mm:ss") - private Date timestamp; + private final Date timestamp; public GeneralResponse(HttpStatus status) { this.timestamp = new Date(); diff --git a/src/main/java/mate/academy/bookstore/response/SuccessResponse.java b/src/main/java/mate/academy/bookstore/response/SuccessResponse.java index 0ca7bda..6cf159c 100644 --- a/src/main/java/mate/academy/bookstore/response/SuccessResponse.java +++ b/src/main/java/mate/academy/bookstore/response/SuccessResponse.java @@ -5,7 +5,7 @@ @Getter public class SuccessResponse extends GeneralResponse { - private T data; + private final T data; public SuccessResponse(T data, HttpStatus status) { super(status);