Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfluxDB timestamp issues #140

Open
hagertnl opened this issue Oct 19, 2023 · 2 comments
Open

InfluxDB timestamp issues #140

hagertnl opened this issue Oct 19, 2023 · 2 comments
Labels
invalid This doesn't seem right

Comments

@hagertnl
Copy link
Contributor

There are two issues I wanted to bring up:

  1. Do we really need nanosecond precision? InfluxDB docs claim that you should use the coarsest precision you can to get the best performance.
  2. Currently, metrics & nodehealth entries do not set a timestamp when they log. If nanoseconds matter, they should set a timestamp. I think they should use the same timestamp as check_end event and log with a precision of milliseconds or coarser, at least for metrics & nodehealth entries, since there is only one entry per test_id.
@hagertnl hagertnl modified the milestone: v3 target fixes Dec 21, 2023
@hagertnl
Copy link
Contributor Author

Removed from v3 target fixes. This likely requires refactoring so that different precisions can be specified for each bucket (ie, nanosecond for events, millisecond for metrics and nodehealth).

@hagertnl
Copy link
Contributor Author

Partial fix in #177 , but still requires both events & metrics & node health to all be logged with the same precision.

@hagertnl hagertnl added the invalid This doesn't seem right label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hagertnl